Restore jQuery 1.2 compatibility, test all supported jQuery minor lines #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BrowserStack succeeds on my fork with code from this PR: https://github.com/mgol/jquery-mousewheel/actions/runs/13859504724 |
timmywil
reviewed
Mar 14, 2025
| @@ -0,0 +1,74 @@ | |||
| version: 1 | |||
There was a problem hiding this comment.
Is the only difference between this file and jtr-isolate.yml the retries and hard-retries? If so, those could be set via cli arguments in the github workflow and we could just have jtr.yml for both local and browserstack.
There was a problem hiding this comment.
@timmywil PR updated, the latest run on my fork is still green: https://github.com/mgol/jquery-mousewheel/actions/runs/13866467470/job/38806483576
It was supported in 3.1.13, so we shouldn't drop it in a minor update; we'll do that in 4.0.0.
mgol
added a commit
to mgol/jquery-mousewheel
that referenced
this pull request
Mar 17, 2025
It was supported in 3.1.13, so we shouldn't drop it in a minor update; we'll do that in 4.0.0. Closes jquerygh-248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery 1.2 was supported in 3.1.13, so we shouldn't drop it in a minor update; we'll do that in 4.0.0.
This is the last PR I'd like to land before the
3.2.0release, after that I'd start dropping legacy stuff & modernizing the build.