Restore jQuery 1.2 compatibility, test all supported jQuery minor lines

It was supported in 3.1.13, so we shouldn't drop it in a minor update; we'll
do that in 4.0.0.

Closes gh-248

Author: mgol

.editorconfig

@@ -4,7 +4,8 @@
 root = true
 
 [*]
-indent_style = tab
+indent_style = space
+indent_size = 4
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = true

.github/workflows/browserstack.yml

@@ -61,6 +61,6 @@ jobs:
 
       - name: Run tests
         run: |
-          npm run test:unit -- -v -c jtr-isolate.yml \
+          npm run test:unit -- -v --retries 3 --hard-retries 1 \
             --browserstack "${{ matrix.BROWSER }}" \
             --run-id ${{ github.run_id }}

ChangeLog.md

@@ -1,5 +1,13 @@
 # Mouse Wheel ChangeLog
 
+## 3.2.0
+
+* Use `.on()`/`.off()` for event binding where available
+* Don't clobber mouse offset properties if we don't adjust them (#165)
+* Remove moot `version` property from bower.json (#140)
+* Remove the executable bit from the library (#176)
+* Add jtr-based tests in GitHub Actions, migrate to ESLint flat config (#247)
+
 ## 3.1.13
 
 * Update copyright notice and license to remove years

jquery.mousewheel.js

@@ -22,11 +22,12 @@
 } )( function( $ ) {
     "use strict";
 
-    var toFix  = [ "wheel", "mousewheel", "DOMMouseScroll", "MozMousePixelScroll" ],
+    var nullLowestDeltaTimeout, lowestDelta,
+        modernEvents = !!$.fn.on,
+        toFix  = [ "wheel", "mousewheel", "DOMMouseScroll", "MozMousePixelScroll" ],
         toBind = ( "onwheel" in window.document || window.document.documentMode >= 9 ) ?
             [ "wheel" ] : [ "mousewheel", "DomMouseScroll", "MozMousePixelScroll" ],
-        slice  = Array.prototype.slice,
-        nullLowestDeltaTimeout, lowestDelta;
+        slice  = Array.prototype.slice;
 
     if ( $.event.fixHooks ) {
         for ( var i = toFix.length; i; ) {
@@ -87,11 +88,13 @@
 
     $.fn.extend( {
         mousewheel: function( fn ) {
-            return fn ? this.on( "mousewheel", fn ) : this.trigger( "mousewheel" );
+            return fn ?
+                this[ modernEvents ? "on" : "bind" ]( "mousewheel", fn ) :
+                this.trigger( "mousewheel" );
         },
 
         unmousewheel: function( fn ) {
-            return this.off( "mousewheel", fn );
+            return this[ modernEvents ? "off" : "unbind" ]( "mousewheel", fn );
         }
     } );
 
@@ -126,7 +129,7 @@
             deltaY = 0;
         }
 
-        // Set delta to be deltaY or deltaX if deltaY is 0 for backwards compatabilitiy
+        // Set delta to be deltaY or deltaX if deltaY is 0 for backwards compatability
         delta = deltaY === 0 ? deltaX : deltaY;
 
         // New school wheel delta (wheel event)
@@ -209,25 +212,23 @@
         // Add event and delta to the front of the arguments
         args.unshift( event, delta, deltaX, deltaY );
 
-        // Clearout lowestDelta after sometime to better
+        // Clear out lowestDelta after sometime to better
         // handle multiple device types that give different
         // a different lowestDelta
         // Ex: trackpad = 3 and mouse wheel = 120
         if ( nullLowestDeltaTimeout ) {
             window.clearTimeout( nullLowestDeltaTimeout );
         }
-        nullLowestDeltaTimeout = window.setTimeout( nullLowestDelta, 200 );
+        nullLowestDeltaTimeout = window.setTimeout( function() {
+            lowestDelta = null;
+        }, 200 );
 
         return ( $.event.dispatch || $.event.handle ).apply( this, args );
     }
 
-    function nullLowestDelta() {
-        lowestDelta = null;
-    }
-
     function shouldAdjustOldDeltas( orgEvent, absDelta ) {
 
-        // If this is an older event and the delta is divisable by 120,
+        // If this is an older event and the delta is divisible by 120,
         // then we are assuming that the browser is treating this as an
         // older mouse wheel event and that we should divide the deltas
         // by 40 to try and get a more usable deltaFactor.

jquery.mousewheel.min.js

@@ -0,0 +1,74 @@
+version: 1
+
+base-url: /test/
+
+runs:
+  jquery:
+    - git
+    - git.min
+    - git.slim
+    - git.slim.min
+    - 3.x-git
+    - 3.x-git.min
+    - 3.x-git.slim
+    - 3.x-git.slim.min
+    - 3.7.1
+    - 3.7.1.min
+    - 3.7.1.slim
+    - 3.7.1.slim.min
+    - 3.6.4
+    - 3.6.4.min
+    - 3.6.4.slim
+    - 3.6.4.slim.min
+    - 3.5.1
+    - 3.5.1.min
+    - 3.5.1.slim
+    - 3.5.1.slim.min
+    - 3.4.1
+    - 3.4.1.min
+    - 3.4.1.slim
+    - 3.4.1.slim.min
+    - 3.3.1
+    - 3.3.1.min
+    - 3.3.1.slim
+    - 3.3.1.slim.min
+    - 3.2.1
+    - 3.2.1.min
+    - 3.2.1.slim
+    - 3.2.1.slim.min
+    - 3.1.1
+    - 3.1.1.min
+    - 3.1.1.slim
+    - 3.1.1.slim.min
+    - 3.0.0
+    - 3.0.0.min
+    - 3.0.0.slim
+    - 3.0.0.slim.min
+    - 2.2.4
+    - 2.2.4.min
+    - 2.1.4
+    - 2.1.4.min
+    - 2.0.3
+    - 2.0.3.min
+    - 1.12.4
+    - 1.12.4.min
+    - 1.11.3
+    - 1.11.3.min
+    - 1.10.2
+    - 1.10.2.min
+    - 1.9.1
+    - 1.9.1.min
+    - 1.8.3
+    - 1.8.3.min
+    - 1.7.2
+    - 1.7.2.min
+    - 1.6.4
+    - 1.6.4.min
+    - 1.5.2
+    - 1.5.2.min
+    - 1.4.4
+    - 1.4.4.min
+    - 1.3.2
+    - 1.3.2.min
+    - 1.2.6
+    - 1.2.6.min

jtr-isolate.yml

@@ -48,7 +48,7 @@
     "test": "npm run build && npm run lint && npm run test:browser"
   },
   "dependencies": {
-    "jquery": ">=1.7.2"
+    "jquery": ">=1.2.6"
   },
   "devDependencies": {
     "@swc/core": "^1.11.8",

jtr.yml

@@ -3,7 +3,7 @@
 <head>
   <meta charset="utf-8">
   <title>jQuery Mousewheel Unit Test</title>
- 
+
   <link rel="stylesheet" href="../node_modules/qunit/qunit/qunit.css">
   <script src="../node_modules/qunit/qunit/qunit.js"></script>
   <script>

package-lock.json

@@ -2,6 +2,9 @@
 
 QUnit.module( "mousewheel" );
 
+var modernEvents = !!jQuery.fn.on,
+    on = modernEvents ? "on" : "bind";
+
 function makeWheelEvent( deltaX, deltaY ) {
     var event = window.document.createEvent( "Event" );
     event.initEvent( "wheel", true, true );
@@ -16,7 +19,7 @@ QUnit.test( ".on() and .trigger()", function( assert ) {
 
     var markup = jQuery( "<div>wheelme</div>" ).appendTo( "body" );
 
-    markup.on( "mousewheel", function( e ) {
+    markup[ on ]( "mousewheel", function( e ) {
         assert.ok( true, "triggered a mousewheel event on " + e.target.innerText );
     } );
     markup.trigger( "mousewheel" );
@@ -46,7 +49,7 @@ QUnit.test( "natively triggered events", function( assert ) {
 
     var markup = jQuery( "<p>wheelme</p>" ).appendTo( "body" );
 
-    markup.on( "mousewheel", function( e ) {
+    markup[ on ]( "mousewheel", function( e ) {
         assert.ok( true, "triggered a mousewheel event on " + e.target.innerText );
         assert.ok( "deltaX" in e, "got a deltaX in the event" );
         assert.ok( !isNaN( parseFloat( e.deltaY ) ), "deltaY is a number: " + e.deltaY );
@@ -67,7 +70,7 @@ QUnit.test( "mouse event properties are passed through", function( assert ) {
 
     var markup = jQuery( "<p>wheelme</p>" ).appendTo( "body" );
 
-    markup.on( "mousewheel", function( e ) {
+    markup[ on ]( "mousewheel", function( e ) {
         var org = e.originalEvent;
         assert.equal( org.clientX, 342, "original event has clientX: " + org.clientX );
         assert.equal( org.clientY, 301, "original event has clientY: " + org.clientY );