Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Don't commit the min file or version to main, add release process #250

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Build: Don't commit the min file or version to main, add release process #250

merged 1 commit into from
Mar 17, 2025

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 14, 2025 •
edited
Loading

Note: only look at the latest commit; the rest is PR #248. That's the only reason this PR is in a draft state.

Changes:

  1. Don't commit the minified file to the main branch.
  2. Move the source file to src/.
  3. Compute the version during the build.
  4. Add a release-it-based release process.

@mgol mgol self-assigned this Mar 14, 2025
@mgol mgol added this to the 4.0.0 milestone Mar 14, 2025
@mgol mgol force-pushed the mousewheel-4.0-src branch 2 times, most recently from 00c0d4c to 65936c0 Compare March 17, 2025 16:24
@mgol mgol marked this pull request as ready for review March 17, 2025 16:25
@mgol mgol force-pushed the mousewheel-4.0-src branch from 65936c0 to c86d5c8 Compare March 17, 2025 16:25
@mgol
Copy link
Member Author

mgol commented Mar 17, 2025

This is ready to review now.

timmywil
timmywil approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to align with other projects

@mgol mgol force-pushed the mousewheel-4.0-src branch from fa25566 to e9f623b Compare March 17, 2025 17:25
@mgol
Copy link
Member Author

mgol commented Mar 17, 2025

I want to do a dry-run before merging this. However, right now it fails as I don't have access to the npm package. I'll wait until I have one and then I'll re-try.

@mgol mgol removed the Needs review label Mar 17, 2025
@mgol mgol force-pushed the mousewheel-4.0-src branch from e9f623b to 432cdc2 Compare March 17, 2025 21:39
@mgol
Build: Don't commit the min file or version to main, add release process
312197c 
Changes:
1. Don't commit the minified file to the `main` branch.
2. Move the source file to `src/`.
3. Compute the version during the build.
4. Add a `release-it`-based release process.
@mgol mgol force-pushed the mousewheel-4.0-src branch from 432cdc2 to 312197c Compare March 17, 2025 22:58
@mgol mgol merged commit d4b04ae into jquery:main Mar 17, 2025
7 checks passed
@mgol mgol deleted the mousewheel-4.0-src branch March 17, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil