playground: Send data unmodified via XHR binary mode. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task 1 is done in gopherjs/gopherjs#167. Creating issue for task 2, made dominikh/go-js-xhr#4. |
We don't want the raw bytes to change from client to server, so send using binary mode. This is done by using []byte parameter, which gets externalized into Uint8Array aka ArrayBufferView, which is one of the parameters that XHR send accepts for sending binary data. See dominikh/go-js-xhr#4 for details.
98fc908 to
f033e2e
Compare
|
All 3 tasks done, this PR is ready to be merged. |
|
On second thought, there are improvements to |
|
Okay, I will merge this as is now because this PR fixes a production issue/task. Code refactoring can be done separately in a followup PR, as it's still ongoing research as to what the best library/API to use. |
dmitshur
added a commit
that referenced
this pull request
Feb 1, 2015
playground: Send data unmodified via XHR binary mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want the raw bytes to change from client to server, so send using binary mode.
This is done by using
[]byteparameter, which gets externalized intoUint8ArrayakaArrayBufferView, which is one of the parameters that XHR send accepts for sending binary data.This is based on my newfound understanding of
ArrayBufferViewfrom discussion at gopherjs/gopherjs@59323cd#commitcomment-9452804. @neelance, I'd like for you to confirm my understanding is correct before merging this.If everything checks out, the XHR package docs should be updated to include that
[]byteis a valid input type for binary transfer.Finally, the .go file needs to be built and likely the entire playground updated via
update.shsince there've been changes to GopherJS compiler.Tasks before merging