Bring string handling more in line with real Go #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The overall change is good and closes #3 (you should mention that). Docs seem clear and accurate to me. I've also tested it in my code, and it compiled and ran correctly. |
| // req := xhr.NewRequest("POST", "http://example.com") | ||
| // req.ResponseType = xhr.ArrayBuffer | ||
| // req.Send([]byte("data")) | ||
| // b := js.Global.Get("Uint8Array").New(req.Response).Interface().([]byte) |
There was a problem hiding this comment.
While this is a logical place for this information to be, I do think it would be more visible and helpful overall to simply move this section to the end of package overview docs.
In Go, strings are usually considered immutable byte slices, and their encoding doesn't matter, at least not when transmitting them as data. JavaScript has a different idea, which leads to strings being sanitized so that they contain valid UTF-8, by replacing invalid byte sequences with replacement runes. Since we're writing this package primarily for Go programmers, we want it to behave as close to "real" Go as possible. That's why the top level Send function is changed to receive binary data and return []byte, and why Request.Send is changed to never pass strings to JS, only []byte. This makes it impossible for someone to actually make use of aforementioned sanitization for outgoing strings, but there's no reason XHR itself should be doing it, and it can be solved in pure Go with a loop. See the discussion at #3 for more information.
3 tasks
Do not convert string to []byte, and explain how to recreate the behaviour of xhr.Send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.