Skip to content

CHI-3735: Fix ContactDetails.tsx redux null checks #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenhand merged 3 commits into from
Feb 16, 2026
Merged

CHI-3735: Fix ContactDetails.tsx redux null checks #3910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88ac35d
Fix ContactDetails redux
stephenhand Feb 16, 2026
20b9e58
Update plugin-hrm-form/src/components/contact/ContactDetails.tsx
stephenhand Feb 16, 2026
4d387c3
Update plugin-hrm-form/src/components/contact/ContactDetails.tsx
stephenhand Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin-hrm-form/src/components/contact/ContactDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const ContactDetails: React.FC<Props> = ({
const definitionVersions = useSelector((state: RootState) => selectDefinitionVersions(state));
const draftCsamReport = useSelector((state: RootState) => state[namespace]['csam-report'].contacts[contactId]);

const { loadingStatus } = savedContactState?.metadata;
const loadingStatus = savedContactState?.metadata?.loadingStatus;
const updateDraftForm = (draftContactId: string, form: Partial<ContactRawJson>) =>
dispatch(updateDraft(draftContactId, { rawJson: form }));
const closeModal = () => dispatch(newCloseModalAction(task.taskSid));
Expand All @@ -90,7 +90,7 @@ const ContactDetails: React.FC<Props> = ({
if (!savedContactState?.savedContact?.conversationMedia && loadingStatus !== 'loading') {
dispatch(loadContactFromHrmByIdAsyncAction(contactId, `${task.taskSid}-viewing`));
}
}, [contactId, dispatch, loadingStatus, savedContactState.savedContact, task.taskSid]);
}, [contactId, dispatch, loadingStatus, savedContactState?.savedContact, task.taskSid]);
const version =
savedContactState?.savedContact?.definitionVersion ?? savedContactState?.savedContact?.rawJson.definitionVersion;

Expand All @@ -107,7 +107,7 @@ const ContactDetails: React.FC<Props> = ({
if (version && !definitionVersions[version]) {
fetchDefinitionVersions();
}
}, [definitionVersions, version, savedContactState.savedContact, dispatch]);
}, [definitionVersions, version, dispatch]);

const definitionVersion = definitionVersions[version];

Expand Down
Loading