Skip to content

Comments

CHI-3735: Fix ContactDetails.tsx redux null checks#3910

Merged
stephenhand merged 3 commits intov2.49-rcfrom
CHI-3735-fix_redux
Feb 16, 2026
Merged

CHI-3735: Fix ContactDetails.tsx redux null checks#3910
stephenhand merged 3 commits intov2.49-rcfrom
CHI-3735-fix_redux

Conversation

@stephenhand
Copy link
Collaborator

Description

Some required null checks look to have been lost in the migration to redux hooks

Checklist

  • Corresponding issue has been opened
  • New tests added
  • [n/a] Feature flags added
  • [n/a] Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand requested a review from gpaoloni February 16, 2026 12:25
@stephenhand stephenhand changed the base branch from master to v2.49-rc February 16, 2026 12:26
@stephenhand stephenhand requested a review from Copilot February 16, 2026 12:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes runtime-safety issues in ContactDetails.tsx where optional Redux state could be undefined after the migration to Redux hooks, restoring required null/undefined handling.

Changes:

  • Guard savedContactState.metadata access to prevent destructuring from undefined.
  • Update useEffect dependency arrays to avoid unsafe property access when savedContactState is missing.

stephenhand and others added 2 commits February 16, 2026 12:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@stephenhand stephenhand merged commit 56dbfe1 into v2.49-rc Feb 16, 2026
55 of 56 checks passed
@stephenhand stephenhand deleted the CHI-3735-fix_redux branch February 16, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant