CHI-3735: Fix ContactDetails.tsx redux null checks#3910
Merged
stephenhand merged 3 commits intov2.49-rcfrom Feb 16, 2026
Merged
CHI-3735: Fix ContactDetails.tsx redux null checks#3910stephenhand merged 3 commits intov2.49-rcfrom
stephenhand merged 3 commits intov2.49-rcfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes runtime-safety issues in ContactDetails.tsx where optional Redux state could be undefined after the migration to Redux hooks, restoring required null/undefined handling.
Changes:
- Guard
savedContactState.metadataaccess to prevent destructuring fromundefined. - Update
useEffectdependency arrays to avoid unsafe property access whensavedContactStateis missing.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some required null checks look to have been lost in the migration to redux hooks
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P