Added documentation for comparison validators #2603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielholmes
commented
May 5, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#790) |
| Applies to | 2.3+ |
| Fixed tickets | none |
|
We did something twice: #2599 But I prefer your one, because you are the creator of those validator :) Thanks for the contribution! |
| **type**: ``mixed`` [:ref:`default option<validation-default-option>`] | ||
|
|
||
| This required option is the comparison value. Validation will fail if the given | ||
| value doesn't equal this comparison value. |
There was a problem hiding this comment.
this option is always the same. Could you please use includes, like I did in my PR? That makes it easier to maintain
|
@wouterj Ahh no I didn't see! Me being the creator of the PR should have no bearing on whether my docs are used. Yours look better in my opinion, so I'm closing this one. Funny that we both decided on the same example (Person and age) |
|
ok, your choice.:) If you have any comments on PR, I'm happy to hear that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.