Skip to content

Documented the Comparison validators #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 5, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 3, 2013

Q A
Doc fix? no
New docs? yes ( symfony/symfony#790 )
Applies to 2.3+
Fixed tickets #2590

I warmly welcome someone who can give me a better example :)

.. caution::

This constraint compares using ``!==``, so ``3`` and ``"3"`` are
considered not equal. Use :doc:`/reference/constraints/NotEqualTo` to compare
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this sentence is weird "are considered not equal". But I wanted to make sure it is related to the NotIdenticalTo validator. If you think it's not readable, it can be changed to "are not considered equal"

@wouterj
Copy link
Member Author

wouterj commented May 4, 2013

Updated the PR with all new validators

weaverryan added a commit that referenced this pull request May 5, 2013
@weaverryan weaverryan merged commit 8a026ea into symfony:master May 5, 2013
@weaverryan
Copy link
Member

Wow Wouter - nice work! This was a lot - I caught a few minor copy-and-paste errors, but much less than I expected for such a big contribution. Thanks for taking this on - I'm sure it was a bit tedious :).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants