[Constraints] Added missing formats #2214
Conversation
| <property name="age"> | ||
| <constraint name="Min"> | ||
| <option name="limit">18</option> | ||
| <option name="message">You must be 18 or older to enter</option> |
There was a problem hiding this comment.
A . at the end should be added to be compliant with most of the constraint entries, shouldn't it?
I know it is really minor but for unification's sake
There was a problem hiding this comment.
@ricarclau, although this is minor it is one of the most important things in the documentation. Consistency is the easiest thing for beginners in tutorials. If they see other things on every page, they will get confused. My target for this documentation is to have a documentation that looks like it is made by one man, but has a big community behind it.
Did you fixed the other sentences in this document?
There was a problem hiding this comment.
Not for this document as it would conflict your changes. I guess best option is that you add . in all parts of constraints/Min and I'll check the rest of constraints.
There was a problem hiding this comment.
@ricardclau, I have added the interpunction.
[Constraints] Added missing formats
|
Thanks @wouterj! |
After this PR, all formats are documented for the constraints in the reference section. This PR adds the XML format for the Regex constraint and cherry picks the XML and PHP config formats for the Min constraint from #2076