-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add missing formats in documentation #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you want, I can help in filling these missing formats Should I start lowest in the list? |
@ricardclau I have done the complete reference at this moment. You can take a look at the cookbook or book sections. Just let us know on which chapters you are going to work, so we don't do something twice. |
Ok! Good to know as I was going to start with the reference :) Looking at the cookbooks... I guess I could take most of them except maybe Symfony1 where I have no experience How do you want to do it? All at once? Picking some sections each one of us? Perhaps we can share a branch to merge all at once? I can start with (and not picking more of them as I don't know exactly how much time I will have during the week): templating/global_variables logging/monolog logging/monolog_email web_services/php_soap_extension Is that ok? |
I think the best option is to split the work. I think sharing a branch is a great idea! Just base your PRs on WouterJ/symfony-docs@add_missing_formats (for the 2.0 branch) and WouterJ/symfony-docs@add_missing_formats_21 (for the 2.1 branch) and I will make a Pull Request if we finished the cookbook. |
Ok, I'll do so, keep in touch! |
Great, thanks for your nice work! I have updated the document to make sure others don't begin with this. |
Hi I am trying to PR to your branches but your fork does not appear in Github combo in the PR dialog. The weird thing is that there are hundreds of other people appearing where I can PR (basically everyone that has ever done a PR to Symfony-docs). Do you know what might be happening? |
@ricardclau it seems just another bug of github... However you can fix it. The pull request url should look like this: This forces github to base the pull request on my branch :) |
Oh url hacks :) First draft done, on my way for PHP config in Monolog |
There are a lot of places where some format is missing. I have created a list of them in this gist: https://gist.github.com/4322564
The formats in Symfony2 are:
One other thing which is related to this: I suggest to change the order in examples showing service configuration files. It is more common to use XML for that.
The text was updated successfully, but these errors were encountered: