Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# [Unreleased](https://github.com/seedco/StackViewController/compare/0.4.0...HEAD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have Changelog under release? So it's all in one place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent for this is to be a document that we keep up-to-date as we make changes. When we do a release we can copy and paste the information in this file to the release notes without having to go back into the git history to figure out what we did.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When new release created with empty description it takes all the changes from commit history.
For me it looked like this:
screen shot 2017-11-23 at 1 02 06 pm

Before it was formatting this way though: Reference to the PR

screen shot 2017-11-23 at 1 03 24 pm


- Fix runtime crashes (unrecognized selector) by adding `@objc` annotation to public UIKit extensions.
4 changes: 2 additions & 2 deletions StackViewController/UIStackViewExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

import UIKit

extension UIStackView {
public func removeAllArrangedSubviews() {
public extension UIStackView {
@objc public func removeAllArrangedSubviews() {
arrangedSubviews.forEach {
$0.removeFromSuperview()
}
Expand Down
4 changes: 2 additions & 2 deletions StackViewController/UIViewExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

import UIKit

extension UIView {
public func activateSuperviewHuggingConstraints(insets: UIEdgeInsets = UIEdgeInsets.zero) -> [NSLayoutConstraint] {
public extension UIView {
@objc public func activateSuperviewHuggingConstraints(insets: UIEdgeInsets = UIEdgeInsets.zero) -> [NSLayoutConstraint] {
translatesAutoresizingMaskIntoConstraints = false
let views = ["view": self]
let metrics = ["top": insets.top, "left": insets.left, "bottom": insets.bottom, "right": insets.right]
Expand Down