Mark UIKit extensions as @objc #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikmeup
approved these changes
Nov 21, 2017
| @@ -0,0 +1,3 @@ | |||
| # [Unreleased](https://github.com/seedco/StackViewController/compare/0.4.0...HEAD) | |||
Contributor
There was a problem hiding this comment.
Would it be possible to have Changelog under release? So it's all in one place
Contributor
Author
There was a problem hiding this comment.
The intent for this is to be a document that we keep up-to-date as we make changes. When we do a release we can copy and paste the information in this file to the release notes without having to go back into the git history to figure out what we did.
Contributor
There was a problem hiding this comment.
When new release created with empty description it takes all the changes from commit history.
For me it looked like this:
Before it was formatting this way though: Reference to the PR
louoso
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashers in the Seed app because the extensions can't be found. Haven't been able to reproduce outside of the Seed app.
This PR also introduces a changelog so we can keep track of what changed between versions.