Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix random doctest error in src/sage/data_structures/bitset.pyx #39827

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix random doctest error in src/sage/data_structures/bitset.pyx #39827

wants to merge 1 commit into from

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Mar 30, 2025 •
edited
Loading

Fixes #39826.

Bitset cannot be build from an empty list. We change the doctest to pass lists with at least 1 element.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Mar 30, 2025
@dcoudert dcoudert mentioned this pull request Mar 30, 2025
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 30, 2025 •
edited
Loading

Documentation preview for this PR (built with commit f23ecb4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

Apparemment Volker a changé un commit de develop, ce qui casse un peu toutes les branches recentes..

@dcoudert
Copy link
Contributor Author

dcoudert commented Apr 1, 2025

J'ai vu ça et je ne sais pas quelle est la bonne commande pour mettre ma branche develop à jour. J'ai posté un message sur sage-release à ce propos.

@fchapoton
Copy link
Contributor

ouais, c'est un chouia penible, meme pour moi. Ca depend un peu de la fraicheur de la branche, il me semble.
Ici, tu as juste deux commits. Je suggere

  • tu tire ta branche en local (git checkout mon_remote/fix_issue_xxxx -b bad_branche), tu recule d'une case (git reset HEAD^)
  • tu te place sur une copie du dernier develop (git checkout develop -b ma_branche) et tu commit
  • tu pousse en force (git push -f) apres avoir bien verifie que tout est ok

dcoudert added a commit to dcoudert/sage that referenced this pull request Apr 1, 2025
@dcoudert
sagemath#39827: fix random doctests
32e2c4e
@dcoudert
Copy link
Contributor Author

dcoudert commented Apr 1, 2025

ma branche develop n'est pas propre. Je sais pas comment la mettre à jour sans refaire un clone complet.. C'est ce que j'ai expliqué dans https://groups.google.com/u/1/g/sage-release/c/kHEhgR91GTo. Je suis pas doué en git...

@fchapoton
Copy link
Contributor

fchapoton commented Apr 2, 2025 •
edited
Loading

  • git checkout develop -b old_bad_dev
  • git branch -D develop
  • git fetch remote_officiel
  • git checkout remote_officiel/develop -b develop

@dcoudert
Copy link
Contributor Author

dcoudert commented Apr 2, 2025

Youhou, ça a marché ! Il me reste à faire de même avec d'autres PR plus compliquée. Merci.

fchapoton
fchapoton approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, merci

@dcoudert
Copy link
Contributor Author

dcoudert commented Apr 3, 2025

Merci à toi pour toute l'aide.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 4, 2025
2661df2 
sagemathgh-39827: fix random doctest error in `src/sage/data_structures/bitset.pyx`
    
Fixes sagemath#39826.

Bitset cannot be build from an empty list. We change the doctest to pass
lists with at least 1 element.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39827
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 5, 2025
bb17483 
sagemathgh-39827: fix random doctest error in `src/sage/data_structures/bitset.pyx`
    
Fixes sagemath#39826.

Bitset cannot be build from an empty list. We change the doctest to pass
lists with at least 1 element.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39827
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 7, 2025
f250883 
sagemathgh-39827: fix random doctest error in `src/sage/data_structures/bitset.pyx`
    
Fixes sagemath#39826.

Bitset cannot be build from an empty list. We change the doctest to pass
lists with at least 1 element.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39827
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 10, 2025
69082dc 
sagemathgh-39827: fix random doctest error in `src/sage/data_structures/bitset.pyx`
    
Fixes sagemath#39826.

Bitset cannot be build from an empty list. We change the doctest to pass
lists with at least 1 element.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39827
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@dcoudert dcoudert

Labels
s: positive review t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

random doctest error in src/sage/data_structures/bitset.pyx
2 participants
@dcoudert @fchapoton