Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor pep8 details in various cython files #39823

Merged
merged 2 commits into from
Apr 2, 2025
Merged

minor pep8 details in various cython files #39823

merged 2 commits into from
Apr 2, 2025

Conversation

fchapoton
Copy link
Contributor

fixing a few things found with cython-lint

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 30, 2025 •
edited
Loading

Documentation preview for this PR (built with commit a97c6d6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

thanks, fixed

@dcoudert
Copy link
Contributor

I have pushed in #39827 a fix for the random doctest error reported in https://github.com/sagemath/sage/actions/runs/14158226546/job/39660250525?pr=39823#step:10:3656

dcoudert
dcoudert approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton fchapoton force-pushed the pep8_cython_minor branch from abc2feb to a97c6d6 Compare April 1, 2025 08:46
dcoudert
dcoudert approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

merci à nouveau, David

@vbraun vbraun merged commit a2b47d6 into sagemath:develop Apr 2, 2025
26 checks passed
@fchapoton fchapoton deleted the pep8_cython_minor branch April 3, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun