Introduce a triton version checking #1608
Conversation
Summary: to avoid confusion after a recent triton upgrade in #1585
torchinductor/utils.py
Outdated
| triton_compiler_version = triton.runtime.version_key().split("-")[6] | ||
| if triton_compiler_version != "7929002797455b30efce6e41eddc6b57": | ||
| log.error( | ||
| "Please update your triton version to af76c989eb4799b015f8b288ccd8421558772e56" |
There was a problem hiding this comment.
Let's include the pip command needed to install it in the error message.
torchinductor/utils.py
Outdated
| @@ -33,6 +35,15 @@ def has_triton(): | |||
| try: | |||
| import triton | |||
|
|
|||
| if triton is not None: | |||
| # This is temp fix to hint people upgrad triton after https://github.com/pytorch/torchdynamo/pull/1585 | |||
| triton_compiler_version = triton.runtime.version_key().split("-")[6] | |||
There was a problem hiding this comment.
Should we disable this check in FBCODE?
There was a problem hiding this comment.
When we sync to fbcode this time, we will have to update trition. So I guess it should be fine.
There was a problem hiding this comment.
Yeah, but then when we want to update the next time this will prevent that upgrade.
torchinductor/utils.py
Outdated
| if triton is not None: | ||
| # This is temp fix to hint people upgrad triton after https://github.com/pytorch/torchdynamo/pull/1585 | ||
| triton_compiler_version = triton.runtime.version_key().split("-")[6] | ||
| if triton_compiler_version != "7929002797455b30efce6e41eddc6b57": |
There was a problem hiding this comment.
Requirering a specific version sounds a bit harsh? If you only want to prevent that error, you can just detect that the function takes more arguments now.
Also you can have an env variable to override this check so that devs that know what they're doing can set it to skip this.
There was a problem hiding this comment.
Switched to checking launch-time exception instead. Should be general enough unless the next time triton upgrade triggers exactly the same error. This can also address Jason's FBCODE concern.
torchinductor/utils.py
Outdated
| log.error( | ||
| "Please update your triton version to af76c989eb4799b015f8b288ccd8421558772e56" | ||
| ) | ||
| exit() |
There was a problem hiding this comment.
Why not raise RuntimeError()
Summary: to avoid confusion after a recent triton upgrade in #1585
Summary: to avoid confusion after a recent triton upgrade in #1585