Move the triton pin #1585
Merged
Move the triton pin #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think some stuff in the new runtime changed (added some args), so we may need to update things. |
I can take a look if you are not already working on it. Another problem here is similar to pytorch/pytorch#93527. Since we don't invalidate codecache if triton version changes, we could start to see different behavior for tests locally. |
|
@desertfire feel free to take this one, I think we just need to add |
7300e96 to
5dbd31d
Compare
|
I see. Since you are calling the |
ngimel
approved these changes
Oct 11, 2022
Summary: The pinned version has a proper fix for #1450
5dbd31d to
4183872
Compare
desertfire
added a commit
that referenced
this pull request
Oct 12, 2022
Summary: to avoid confusion after a recent triton upgrade in #1585
desertfire
added a commit
that referenced
this pull request
Oct 13, 2022
Summary: to avoid confusion after a recent triton upgrade in #1585
fdrocha
pushed a commit
that referenced
this pull request
Oct 13, 2022
Summary: to avoid confusion after a recent triton upgrade in #1585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: you need to upgrade triton after this PR.
Summary:
leview is different between Inductor and Torch #1564