Add SKIPIF section for not always available functions #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Removed |
staabm
reviewed
Feb 22, 2018
| --SKIPIF-- | ||
| <?php if (!is_executable('/bin/cat')) echo 'skip cat not found'; ?> | ||
| <?php | ||
| if (!is_executable('/bin/cat')) echo 'skip cat not found'; |
Contributor
There was a problem hiding this comment.
any difference between echo 'skip not found'; and die 'skip proc_open..' ?
Contributor
Author
There was a problem hiding this comment.
@staabm The only one that I know is, with we run the generated test.sh, it would break. die would return the message and kill the script.
Contributor
There was a problem hiding this comment.
Should echo or die be unified ?
Contributor
Author
There was a problem hiding this comment.
@staabm Sure it does, SKIPIF should use die. QA recommends this already.
I'm waiting for this one, related to unifying requirement for skipif.inc, then we can unify this as well 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3065. Refs:
getservbyname: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2894;getservbyport: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2873;getprotobynumber: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2906;time_nanosleep: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2729;proc_open: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2873gmstrftime: https://github.com/php/php-src/blob/master/ext/date/php_date.c#L417uniqid: https://github.com/php/php-src/blob/master/ext/standard/basic_functions.c#L2997