Skip to content

Conversation

@carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Feb 4, 2018

AFAIK, the skipif.inc always lived in the same directory, and IMHO we don't need these complex statements to require it. A simple require 'skipif.inc' resolves, right?

Also, I've unified to require, as (if I'm not wrong) is safer than include and faster than require_once and include_once 😄

@krakjoe
Copy link
Member

krakjoe commented Feb 8, 2018

I'm not sure about this, it's technically true that once variants are slower, but in this case whatever function is used is just causing the interpreter to exit, and the difference won't amount to anything meaningful.

I'm also not sure that future test writers will care about the conventions you are trying to establish.

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Feb 8, 2018

I'm also not sure that future test writers will care about the conventions you are trying to establish.

@krakjoe I can compromise myself to review new tests, but also, we can do this by updating our Quality Assurance. What do you think?

@carusogabriel
Copy link
Contributor Author

Closing as we shouldn't standardize such thing

@carusogabriel carusogabriel deleted the simplify-skipif branch July 13, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants