-
-
Notifications
You must be signed in to change notification settings - Fork 144
ENH: Add default mypy and pyright tasks #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add simplet task names to simplify running tools
@twoertwein Not sure how you feel about these, but I like the idea of just running |
Cannot you already do that with |
Happy to shorten |
That is my idea. To have a "default" mypy which would just be called mypy. Same for pyright. I'm used to using |
I have removed the three comands that end in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change in the docs
docs/tests.md
Outdated
@@ -1,11 +1,11 @@ | |||
## Test | |||
|
|||
- Run local tests against source code. </br> `poe test_src` </br> </br> | |||
- Run local tests against source code. </br> `poe test` </br> </br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say which is the default profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no more profiles, that's why I opened #162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bashtage
Add simpler task names to simplify running tools