Skip to content

ENH: Add default mypy and pyright tasks #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Conversation

bashtage
Copy link
Contributor

Add simpler task names to simplify running tools

Add simplet task names to simplify running tools
@bashtage
Copy link
Contributor Author

@twoertwein Not sure how you feel about these, but I like the idea of just running poe mypy like I run poe pytest. This only runs one of the mypy tasks, but that it usually enough to find any errors IME.

@bashtage bashtage requested a review from twoertwein July 22, 2022 17:38
@twoertwein
Copy link
Member

@twoertwein Not sure how you feel about these, but I like the idea of just running poe mypy like I run poe pytest. This only runs one of the mypy tasks, but that it usually enough to find any errors IME.

Cannot you already do that with poe pyright_src and poe mypy_src (or did I accidentally remove that)?

@twoertwein
Copy link
Member

Happy to shorten mypy_src to mypy and pyright_src to pyright - but we shoud not have both mypy and mypy_src

@bashtage
Copy link
Contributor Author

Happy to shorten mypy_src to mypy and pyright_src to pyright - but we shoud not have both mypy and mypy_src

That is my idea. To have a "default" mypy which would just be called mypy. Same for pyright. I'm used to using mypy <project>, so something like poe mypy feels intuitive (like poe pytest since pytest <project> is more common).

@bashtage
Copy link
Contributor Author

I have removed the three comands that end in src so that their "base"s are now the preferred names

poe mypy
poe pyright
poe test

Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@Dr-Irv

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change in the docs

docs/tests.md Outdated
@@ -1,11 +1,11 @@
## Test

- Run local tests against source code. </br> `poe test_src` </br> </br>
- Run local tests against source code. </br> `poe test` </br> </br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say which is the default profile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no more profiles, that's why I opened #162

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashtage

@Dr-Irv Dr-Irv merged commit 162dac8 into pandas-dev:main Jul 24, 2022
@bashtage bashtage deleted the alias-poe branch August 23, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants