Skip to content

update docs #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2022
Merged

update docs #162

merged 4 commits into from
Jul 24, 2022

Conversation

twoertwein
Copy link
Member

updated tests.md, style.md is already covered in tests.md, and removed html formatting tags.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change suggested

docs/tests.md Outdated

- Run all local tests: </br> `poe test_all` </br> </br>
- Run all tests (includes installing the stubs): `poe test_all`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say "includes testing the stubs when installed"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_all installes the stubs, then tests them, and then uninstalled them

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but the remark seems to indicate that it is just installing the stubs. So that's why I suggested the change.

How about "includes testing stubs as installed"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main and slightly modified the existing description

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein

@Dr-Irv Dr-Irv merged commit 285350c into pandas-dev:main Jul 24, 2022
@twoertwein twoertwein deleted the tests branch September 21, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants