BaseControl, SelectBox: labels and prompt are translated by global translator

[dg]

This is just idea.

Error messages are since 6451fe0 translated by form's translator instead of control's one. It turned out to be the right decision. What about labels? I think that labels should be translated by form's translator too.

Maybe selectbox prompt too, but I am not sure.

[JanTvrdik]

So – what would the control's translator be for?

[dg]

setTranslator has sense for items on Choice & MultiChoiceControl.

[solcik]

I would very welcome this approach. Label and prompt via form's translator and items via control's. So It would not be needed to hack it - setTranslator(NULL) and then manually translate label and prompt.

[Olicek]

Will this PR in Nette 2.3?

[tomaswindsor]

I like the idea, but I suggest using overridable control's methods like getOuterTranslator() and getItemsTranslator(), which would in their default implementation work as outlined above (getOuterTranslator() would return form's translator and getItemsTranslator() would return control's translator. Purpose is simply to make it possible to modify the behavior via inheritance.

Alternatively there could be properties and public setters for both types of these translators (setItemsTranslator, setOuterTranslator) and the default behavior could again be the same as outlined above.

[zraly]

So what is the result? It seems, that it is still not possible to translate control with form translator, but leave control items untranslated. Is that right? Because use case, when selectbox items are gathered from database is very common.

[dg]

I think it can be merged to 3.0-dev