SelectBox: options translation can be disabled

[castamir]

To prevent SelectBox values from being translated, we had to disable entire translator from this control and translate label and option-descript manualy.

I propose an opposite aproach - possibility to not translate these values =)

[Majkl578]

What an ugly name. What about $translateValues = TRUE?

[castamir]

That was my first shot, but what about it's setter? From the name translateValues() I would guess that that method will return translated values and not just set a flag. Also logic of such method might be confusing (inverted)... What do you think?

[TomasVotruba]

The confusion might be caused by double negation. Rather then $disable<sth> = FALSE, which means "it's ok, go", bool value should start with verb, like in question (e.g. "is container generated?"). I'd suggest $doTranslateValue, or rather $doTranslateOptions, because it's called on $options property.

@castamir Great idea btw. We use custom select box with translations off by default on it's values.

[castamir]

@TomasVotruba thx for response.

[TomasVotruba]

Missing bool annotation

[TomasVotruba]

👍

[solcik]

👍

[castamir]

ping @dg

Could you please give me some feedback?

[dg]

doTranslateOptions is really bad name. I am considering another approach #58 …