Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e/framework): don't fail when some debug commands will fail #11342

Merged
merged 1 commit into from
Sep 9, 2024
Merged

ci(e2e/framework): don't fail when some debug commands will fail #11342

merged 1 commit into from
Sep 9, 2024

Conversation

bartsmykla
Copy link
Contributor

There are situations where we are calling Debug* helper e2e framework functions multiple times. So far if one of them would fail, it stops other from execution. This commit changes this behavior to just log warning in such situations.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Changelog: skip

@bartsmykla
ci(e2e/framework): don' fail when some debug commands will fail
f79a236 
There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested a review from a team as a code owner September 9, 2024 10:38
@bartsmykla bartsmykla requested review from jakubdyszkiewicz and removed request for a team September 9, 2024 10:38
@bartsmykla bartsmykla enabled auto-merge (squash) September 9, 2024 10:40
@bartsmykla bartsmykla merged commit 0a36646 into kumahq:master Sep 9, 2024
17 of 18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

backporting to release-2.6 with action

backporting to release-2.5 with action
backporting to release-2.7 with action
backporting to release-2.8 with action

kumahq bot pushed a commit that referenced this pull request Sep 9, 2024
@bartsmykla @kumahq
ci(e2e/framework): don't fail when some debug commands will fail (#11342
486d187 
)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 9, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Sep 9, 2024
@bartsmykla @kumahq
ci(e2e/framework): don't fail when some debug commands will fail (#11342
6e61eba 
)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 9, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Sep 9, 2024
@bartsmykla @kumahq
ci(e2e/framework): don't fail when some debug commands will fail (#11342
f58039c 
)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 9, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Sep 9, 2024
@bartsmykla @kumahq
ci(e2e/framework): don't fail when some debug commands will fail (#11342
20dfec3 
)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 9, 2024
Merged
bartsmykla pushed a commit that referenced this pull request Sep 9, 2024
@kumahq
ci(e2e/framework): don't fail when some debug commands will fail (bac…
17be7c8 
…kport of #11342) (#11347)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartsmykla @slonka