Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e/framework): don't fail when some debug commands will fail (backport of #11342) #11344

Closed
wants to merge 1 commit into from
Closed

ci(e2e/framework): don't fail when some debug commands will fail (backport of #11342) #11344

wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Sep 9, 2024

Automatic cherry-pick of #11342 for branch release-2.6

Generated by action

cherry-picked commit 0a36646
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.6
Your branch is up to date with 'origin/release-2.6'.

You are currently cherry-picking commit 0a366462a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   test/framework/debug.go

no changes added to commit (use "git add" and/or "git commit -a")

@bartsmykla @kumahq
ci(e2e/framework): don't fail when some debug commands will fail (#11342
486d187 
)

There are situations where we are calling `Debug*` helper e2e framework
functions multiple times. So far if one of them would fail, it stops
other from execution. This commit changes this behavior to just log
warning in such situations.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner September 9, 2024 11:59
@kumahq kumahq bot requested review from slonka and jakubdyszkiewicz and removed request for a team September 9, 2024 11:59
@bartsmykla bartsmykla closed this Sep 9, 2024
@bartsmykla bartsmykla deleted the chore/backport-release-2.6-11342 branch September 9, 2024 12:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
conflict release-2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartsmykla