Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Drop support for jQuery UI 1.11 & below #613

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented May 10, 2024

NOTE: The PR is ready for review but it should not land before June, 2024 due to commitments laid out in https://blog.jqueryui.com/2024/04/plans-for-jquery-ui-1-14-dropping-support-for-ui-1-12-in-the-download-builder/

Update: the PR can land even now, just don't bump the deployed branch before June.

@mgol mgol requested a review from fnagel May 10, 2024 14:50
@mgol mgol marked this pull request as draft May 11, 2024 22:20
@mgol mgol requested a review from timmywil May 13, 2024 22:33
@mgol mgol marked this pull request as ready for review May 13, 2024 22:33
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with all of this code, but I didn't see anything glaringly wrong. I would trust Felix's approval more than mine.

@mgol
Copy link
Member Author

mgol commented May 14, 2024

This PR doesn't have to land before the first beta - but before the second one which should come out in June - so I can wait a few more weeks for Felix's review.

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

Please note that I've never helped with all the build / download / theme roller stuff, so I'm not really familiar with the code. From what I've seen, it looks good.

@mgol mgol removed the Needs review label May 29, 2024
@mgol mgol merged commit db1d514 into jquery:main May 29, 2024
3 checks passed
@mgol mgol deleted the drop-1-11 branch May 29, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants