Various refactors, removals of legacy dependencies, etc. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnagel
approved these changes
May 24, 2024
The previous implementation saved a new timeout ID in a local variable that would be lost after a re-run. This mistake was introduced in commit 7162a1d. Ref jquerygh-615
Use `parseArgs` from the built-in `node:util` instead. Ref jquerygh-615
Use native JS APIs instead. Ref jquerygh-615
|
Landed in 7e2ab30...8d194a0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: As of now, this PR includes #613 in its first commit. That PR needs to land first! To review this PR, either go commit by commit, ingoring the first one, or review at my fork at mgol#1 where that commit is missing.After dropping support for jQuery UI <1.12, it's possible to simplify the code a bit, remove redundant dependencies, etc. This PR does that.