Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themeroller: Fix stale cachedZThemeParams in themeroller-themegallery #609

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 19, 2024

Also, add a test for their correctness.

Fixes gh-602

@mgol mgol requested review from fnagel and timmywil April 19, 2024 13:18
@mgol mgol self-assigned this Apr 19, 2024
@mgol
Copy link
Member Author

mgol commented Apr 19, 2024

It turns out that the values for the Base & Vader themes were incorrect. I updated all the values in this PR so that they're compressed with the latest LZMA version.

@mgol mgol merged commit f542257 into jquery:main Apr 19, 2024
3 checks passed
@mgol mgol deleted the cachedZThemeParams-fix branch April 19, 2024 15:03
@mgol mgol removed the Needs review label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to download customized theme
2 participants