Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to download customized theme #602

Closed
Mark-Boyce opened this issue Sep 18, 2023 · 6 comments · Fixed by #609
Closed

Attempting to download customized theme #602

Mark-Boyce opened this issue Sep 18, 2023 · 6 comments · Fixed by #609

Comments

@Mark-Boyce
Copy link

After making a few customizations, attempting to download the theme results in a 404 error and the customizations are not downloaded.

@mueslinibbles
Copy link

mueslinibbles commented Nov 6, 2023

Likewise, getting the same problem.
Customise the theme then goto the download page and get a 'service unavailable' error
Screenshot 2023-11-06 164804

Theme downloads, but devoid of any customised images/icon files.

@mgol
Copy link
Member

mgol commented Nov 6, 2023

@mueslinibbles @Mark-Boyce is the behavior reproducible? Does it happen all the time or periodically? Can you lay out very, very precise steps to reproduce? Exactly which URL you visit, what you click/type, step by step.

I need this as just if I try to change a few things, I can download the themed package without issues.

@mueslinibbles
Copy link

Yes, this is happening every time I try to download either the base theme, or a customisation of it.
Simplest, repeatable, route to the error is;

  1. Goto https://jqueryui.com/
  2. Click 'Themes' from menu
  3. Goto the 'Gallery' tab of the ThemeRoller.
  4. Select the Base theme.
  5. Click the download button.
  6. The Download Builder window appears, then after a moment the 'service unavailable' 404 error box appears.

hope this helps.

@mgol
Copy link
Member

mgol commented Nov 6, 2023

Thank you! I can reproduce it now.

From what I see, there's a request triggered to https://download.jqueryui.com/download/theme?themeParams=ffDefault%3D... and that results in a 500 with the following stack trace:

Error: No dimensions set for texture "none"
    at ThemeRoller._textureUrl (/app/lib/themeroller.js:270:10)
    at new ThemeRoller (/app/lib/themeroller.js:160:29)
    at Frontend.theme (/app/download.js:195:20)
    at /app/server.js:97:35
    at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/app/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/app/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
    at /app/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/app/node_modules/express/lib/router/index.js:341:12)

@mgol
Copy link
Member

mgol commented Apr 13, 2024

A workaround for now is to avoid clicking "Download" on a theme but instead to click "Edit" and then "Download theme".

mgol added a commit to mgol/download.jqueryui.com that referenced this issue Apr 19, 2024
mgol added a commit to mgol/download.jqueryui.com that referenced this issue Apr 19, 2024
@mgol
Copy link
Member

mgol commented Apr 19, 2024

It turns out that the values for the Base & Vader themes were incorrect. I updated all the values in this PR so that they're compressed with the latest LZMA version.

PR: #609

@mgol mgol closed this as completed in #609 Apr 19, 2024
mgol added a commit that referenced this issue Apr 19, 2024
Also, add a test for their correctness.

Fixes gh-602
Closes gh-609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants