Build: Switch from Node 14 to 18, update/remove dependencies #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
reviewed
Apr 19, 2024
| path = require( "path" ), | ||
| rimraf = require( "rimraf" ), | ||
| fs = require( "node:fs" ), | ||
| fsp = require( "node:fs/promises" ), |
There was a problem hiding this comment.
Could all calls be switched to use one or the other?
There was a problem hiding this comment.
There are sync-only APIs like existsSync or createWriteStream so node:fs/promises cannot be used for everything. There are some cases that could potentially be migrated to the promises version but validating I didn't break anything would require some time. I'd rather postpone any such code refactors until after jQuery UI <1.12 support is dropped from this repo.
There was a problem hiding this comment.
@timmywil I’m going to merge this since I have 1 approval and this blocks multiple other PRs. Let me know if you have further feedback and I’ll address it separately.
This was referenced Apr 19, 2024
Changes: * switch from Node 14 to 18, including in the Dockerfile * test on Node 18 & 20 * update almost all dependencies * remove some dependencies Removed dependencies: * `rimraf` in favor of native `fs` which now has recursive removal * `dateformat` that was rarely used in favor of native `Date` usage Closes jquerygh-608
…a-bug. Fixes jquery#79". Fixes jquery#131 This reverts commit 4f6405b. Ref jquerygh-608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removed dependencies:
rimrafin favor of nativefswhich now has recursive removaldateformatthat was rarely used in favor of nativeDateusageAlso:
Reapply "Remove the workaround to handle asynchronous worker load lzma-bug. Fixes #79". Fixes #131
This reverts commit 4f6405b.
And:
Build: Add .editorconfig, reformat package.json & package-lock.json