Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add Themeroller tests #611

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Tests: Add Themeroller tests #611

merged 1 commit into from
Apr 21, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 19, 2024

Lots of ThemeRoller code is duplicated between this repo & jquery-ui-themeroller. I hope to unify it once code handling UI <1.12 is dropped.

Ref jquery-archive/jquery-ui-themeroller#18

@mgol mgol requested review from fnagel and timmywil April 19, 2024 22:31
@mgol mgol self-assigned this Apr 19, 2024
@mgol
Copy link
Member Author

mgol commented Apr 20, 2024

Tests only fail on Node 10 but that doesn't matter; we're migrating to 18 + 20 in #608. That other PR should land before this one but it can be reviewed even before that.

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol force-pushed the themeroller-tests branch from 2b1f091 to 84c1b94 Compare April 21, 2024 18:46
@mgol mgol removed the Needs review label Apr 21, 2024
@mgol mgol merged commit d225761 into jquery:main Apr 21, 2024
3 checks passed
@mgol mgol deleted the themeroller-tests branch April 21, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants