fix(taskworker) Reduce usage of countdown #88639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of short `countdown` durations for tasks and use `transaction.on_commit()` instead. These tasks appear to be using `countdown` as a way to prevent tasks being processed before postgres transactions are complete. Refs #88091
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88639 +/- ##
========================================
Coverage 87.75% 87.76%
========================================
Files 10032 10032
Lines 568031 568137 +106
Branches 22310 22310
========================================
+ Hits 498502 498613 +111
+ Misses 69109 69104 -5
Partials 420 420 |
evanh
approved these changes
Apr 3, 2025
enochtangg
approved these changes
Apr 3, 2025
enochtangg
added a commit
that referenced
this pull request
Apr 3, 2025
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this [document](https://www.notion.so/sentry/Rollout-Planning-1bd8b10e4b5d80aeaaa7dba0efca83bc). ### Notes: - Updates `auto_resolve_snapshot_incidents` tasks to only produce task after incident status is updated - Depends on #88639 which fixes countdown for the rest of the snuba subscription tasks --------- Co-authored-by: Mark Story <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Remove usage of short `countdown` durations for tasks and use `transaction.on_commit()` instead. These tasks appear to be using `countdown` as a way to prevent tasks being processed before postgres transactions are complete. Refs #88091
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this [document](https://www.notion.so/sentry/Rollout-Planning-1bd8b10e4b5d80aeaaa7dba0efca83bc). ### Notes: - Updates `auto_resolve_snapshot_incidents` tasks to only produce task after incident status is updated - Depends on #88639 which fixes countdown for the rest of the snuba subscription tasks --------- Co-authored-by: Mark Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of short
countdowndurations for tasks and usetransaction.on_commit()instead. These tasks appear to be usingcountdownas a way to prevent tasks being processed before postgres transactions are complete.Refs #88091