feat(taskworkers): Make alerts taskworker compatible #88696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88696 +/- ##
==========================================
+ Coverage 84.59% 87.73% +3.13%
==========================================
Files 10054 10055 +1
Lines 568655 568791 +136
Branches 22322 22322
==========================================
+ Hits 481054 499006 +17952
+ Misses 87222 69406 -17816
Partials 379 379 |
evanh
approved these changes
Apr 3, 2025
markstory
approved these changes
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this [document](https://www.notion.so/sentry/Rollout-Planning-1bd8b10e4b5d80aeaaa7dba0efca83bc). ### Notes: - Updates `auto_resolve_snapshot_incidents` tasks to only produce task after incident status is updated - Depends on #88639 which fixes countdown for the rest of the snuba subscription tasks --------- Co-authored-by: Mark Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this document.
Notes:
auto_resolve_snapshot_incidentstasks to only produce task after incident status is updated