Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(crons): Remove Monitor type field (state) #88496

Merged

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested review from a team as code owners April 1, 2025 21:08
@evanpurkhiser evanpurkhiser removed request for a team April 1, 2025 21:08
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0856_monitors_remove_type_column_state.py ()

--
-- Moved monitor.type field to pending deletion state
--
-- (no-op)

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch from 8892701 to c1627ee Compare April 1, 2025 21:14
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, make sure not to merge this until the other pr finishes deploying

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88496      +/-   ##
==========================================
+ Coverage   84.62%   87.75%   +3.13%     
==========================================
  Files       10027    10028       +1     
  Lines      567857   567961     +104     
  Branches    22310    22310              
==========================================
+ Hits       480531   498432   +17901     
+ Misses      86906    69109   -17797     
  Partials      420      420              

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch from 7bbfe83 to 05755b8 Compare April 1, 2025 21:36
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch from 7c79870 to dc72066 Compare April 1, 2025 22:09
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch from d6ba332 to e85f1de Compare April 2, 2025 19:38
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch from 9e1841f to 19ac45c Compare April 2, 2025 20:32
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 2, 2025 20:55
@evanpurkhiser evanpurkhiser merged commit ac71df3 into master Apr 2, 2025
46 of 47 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-remove-monitor-type-field-state- branch April 2, 2025 21:06
adrian-codecov pushed a commit that referenced this pull request Apr 3, 2025
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
evanpurkhiser added a commit that referenced this pull request Apr 3, 2025
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants