Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(crons): Remove monitor type field (db) #88695

Merged
merged 1 commit into from
Apr 3, 2025
Merged

ref(crons): Remove monitor type field (db) #88695

merged 1 commit into from
Apr 3, 2025

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Apr 3, 2025 •
edited
Loading

Follow up to #88496

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner April 3, 2025 16:24
@evanpurkhiser evanpurkhiser requested review from a team April 3, 2025 16:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0858_monitors_remove_type_column_db.py ()

--
-- Remove field type from monitor
--
ALTER TABLE "sentry_monitor" DROP COLUMN "type" CASCADE;

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-db- branch from 4817d9b to 67a9567 Compare April 3, 2025 16:34
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitor-type-field-db- branch from 67a9567 to 29c5f7e Compare April 3, 2025 16:37
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 3, 2025 16:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0859_monitors_remove_type_column_db.py ()

--
-- Remove field type from monitor
--
ALTER TABLE "sentry_monitor" DROP COLUMN "type" CASCADE;

@evanpurkhiser evanpurkhiser merged commit 9930509 into master Apr 3, 2025
47 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-remove-monitor-type-field-db- branch April 3, 2025 17:07
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@evanpurkhiser @andrewshie-sentry
ref(crons): Remove monitor type field (db) (#88695)
2385fac 
Follow up to #88496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @wedamija