Skip to content

fix(board): Fix wESP32 board config with new options #11879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −2
Open

fix(board): Fix wESP32 board config with new options #11879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c4366
fix(board): Fix wESP32 board config with new options
xorbit Sep 27, 2025
e92ad53
fix(board): Fix wESP32 board config typo
xorbit Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion boards.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29533,7 +29533,7 @@ wesp32.build.board=WESP32

wesp32.build.f_cpu=240000000L
wesp32.build.flash_mode=dio
wesp32.build.flash_size=4MB
wesp32.build.flash_size=16MB
wesp32.build.boot=dio
wesp32.build.partitions=default
wesp32.build.defines=
Expand All @@ -29543,6 +29543,23 @@ wesp32.menu.FlashFreq.80.build.flash_freq=80m
wesp32.menu.FlashFreq.40=40MHz
wesp32.menu.FlashFreq.40.build.flash_freq=40m

wesp32.menu.FlashSize.default=16MB (128Mb) rev 7+
wesp32.menu.FlashSize.default.build.flash_size=16MB
wesp32.menu.FlashSize.default_4m_flash=4MB (32Mb) rev 5 and below
wesp32.menu.FlashSize.default_4m_flash.build.flash_size=4MB

wesp32.menu.PartitionScheme.default=16M OTA with large SPIFFS (4.5MB APP/6.8MB SPIFFS)
wesp32.menu.PartitionScheme.default.build.partitions=large_spiffs_16MB
wesp32.menu.PartitionScheme.default.upload.maximum_size=4718592
wesp32.menu.PartitionScheme.default_large_app=16M large OTA app with SPIFFS (6.2MB APP/3.3MB SPIFFS)
wesp32.menu.PartitionScheme.default_large_app.build.partitions=default_16MB
wesp32.menu.PartitionScheme.default_large_app.upload.maximum_size=6553600
wesp32.menu.PartitionScheme.default_fatfs=16M OTA with large FATFS (3MB APP/9.8MB FATFS)
wesp32.menu.PartitionScheme.default_fatfs.build.partitions=app3M_fat9M_16MB
wesp32.menu.PartitionScheme.default_fatfs.upload.maximum_size=3145728
wesp32.menu.PartitionScheme.default_4m_flash=4M OTA app with SPIFFS (1.25MB APP/1.3MB SPIFFS)
wesp32.menu.PartitionScheme.default_4m_flash.build.partitions=default

wesp32.menu.UploadSpeed.921600=921600
wesp32.menu.UploadSpeed.921600.upload.speed=921600
wesp32.menu.UploadSpeed.115200=115200
Expand Down
2 changes: 1 addition & 1 deletion variants/wesp32/pins_arduino.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ static const uint8_t T9 = 32;
#define ETH_PHY_POWER -1
#define ETH_PHY_MDC 16
#define ETH_PHY_MDIO 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having also #define ETH_PHY_TYPE_REV4 ETH_PHY_LAN8720 in case someone uses the old revision to keep backward compatibility.

Copy link
Contributor Author

@xorbit xorbit Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my examples, I have usually called out just setting all parameters:
https://wesp32.com/software/#arduino-esp32

With the change in this PR, users now could just use ETH.begin() for any wESP32 sold in the last 4 years.

The only revisions ever sold are rev 3, 4 and 5 with LAN8720, sold for about 3 years (2018 ~ 2021), and rev 7 and 8 with RTL8201, sold the last 4 years (2021 ~ present). I'm not sure how to clearly communicate what another define would be for exactly. It's not just revision 4, it's 3, 4 and 5 you'd use LAN8720 for. I don't see how any new #define we'd come up with would be clearer than to just say "this board needs LAN8720" and use the ETH_PHY_LAN8720 name directly.

#define ETH_PHY_TYPE ETH_PHY_LAN8720
#define ETH_PHY_TYPE ETH_PHY_RTL8201
#define ETH_CLK_MODE ETH_CLOCK_GPIO0_IN

#endif /* Pins_Arduino_h */