Skip to content

fix(board): Fix wESP32 board config with new options #11879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(board): Fix wESP32 board config with new options #11879

wants to merge 2 commits into from
+19 −2

Conversation

xorbit
Copy link
Contributor

@xorbit xorbit commented Sep 27, 2025

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

  • Provide flash size option to choose 4MB flash (rev 5 and below) or 16MB flash (default, rev 7 and higher).
  • Provide appropriate partition scheme options to effectively use either 4MB or 16MB flash sizes.
  • Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and higher default).

Test Scenarios

Tested on Arduino 2.3.6 locally with wESP32 rev 8 board.

@xorbit
fix(board): Fix wESP32 board config with new options
25c4366 
- Provide flash size option to choose 4MB flash (rev 5 and below)
  or 16MB flash (default, rev 7 and higher).
- Provide appropriate partition scheme options to effectively us
  either 4MB or 16MB flash sizes.
- Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and
  higher).
@xorbit
fix(board): Fix wESP32 board config typo
e92ad53
@xorbit xorbit requested a review from P-R-O-C-H-Y as a code owner September 27, 2025 00:29
@github-actions GitHub Actions
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello xorbit, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e92ad53

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Sep 29, 2025
P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Sep 29, 2025
View reviewed changes
variants/wesp32/pins_arduino.h
#define ETH_PHY_ADDR 0
#define ETH_PHY_POWER -1
#define ETH_PHY_MDC 16
#define ETH_PHY_MDIO 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having also #define ETH_PHY_TYPE_REV4 ETH_PHY_LAN8720 in case someone uses the old revision to keep backward compatibility.

Copy link
Contributor Author

@xorbit xorbit Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my examples, I have usually called out just setting all parameters:
https://wesp32.com/software/#arduino-esp32

With the change in this PR, users now could just use ETH.begin() for any wESP32 sold in the last 4 years.

The only revisions ever sold are rev 3, 4 and 5 with LAN8720, sold for about 3 years (2018 ~ 2021), and rev 7 and 8 with RTL8201, sold the last 4 years (2021 ~ present). I'm not sure how to clearly communicate what another define would be for exactly. It's not just revision 4, it's 3, 4 and 5 you'd use LAN8720 for. I don't see how any new #define we'd come up with would be clearer than to just say "this board needs LAN8720" and use the ETH_PHY_LAN8720 name directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y left review comments

+1 more reviewer

@wootangk wootangk wootangk approved these changes

Reviewers whose approvals may not affect merge requirements

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorbit @P-R-O-C-H-Y @wootangk