Skip to content

use one line boolean condition with add types #9666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

use one line boolean condition with add types #9666

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c743651
- one line boolean condition
ArtemIsmagilov Mar 17, 2025
715ea1d
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
4a70c9d
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
7f27675
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
6ff2ced
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
2f288fc
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
56b4ce2
Update rest_framework/utils/timezone.py
tomchristie Mar 21, 2025
8b59d98
remove unused datetime module
ArtemIsmagilov Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions rest_framework/utils/timezone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import datetime, timezone, tzinfo
from datetime import timezone, tzinfo


def datetime_exists(dt):
Expand All @@ -9,7 +9,7 @@ def datetime_exists(dt):
return dt.astimezone(timezone.utc) == dt


def datetime_ambiguous(dt: datetime):
def datetime_ambiguous(dt):
"""Check whether a datetime is ambiguous. Taken from: https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html"""
# If a datetime exists and its UTC offset changes in response to
# changing `fold`, it is ambiguous in the zone specified.
Expand All @@ -20,6 +20,4 @@ def datetime_ambiguous(dt: datetime):

def valid_datetime(dt):
"""Returns True if the datetime is not ambiguous or imaginary, False otherwise."""
if isinstance(dt.tzinfo, tzinfo) and not datetime_ambiguous(dt):
return True
return False
return isinstance(dt.tzinfo, tzinfo) and not datetime_ambiguous(dt)
Loading