use one line boolean condition with add types

[ArtemIsmagilov]

simple refactoring

[tomchristie]

The valid_datetime change is cleaner, okay. We're not generally accepting these types of PRs, tho one part of this is sufficiently obvious and reasonable. (We could put even harder boundaries in place here?)

Some suggested changes here to keep the codebase consistent.

[browniebroke]

We're not generally accepting these types of PRs, tho one part of this is sufficiently obvious and reasonable. (We could put even harder boundaries in place here?)

I think we need to behave consistently in accepting these kind of PRs: we either accept them or we don't. Yes it's a trivial change but accepting this will IMO open the door to others (e.g. might be harder to decline these #9286 #9285).

I looked up to see if there was a clear technical benefit (from the machine perspective) of making this change and didn't find a compelling argument. Ruff has a page for each rule that usually make a good case for them and according to this one, it seems to be mostly about readability...

With that in mind, I'm -1 for this change, unless we find a way to rephrase the note from our contributing page, which currently reads:

At this point in its lifespan we consider Django REST framework to be feature-complete. We focus on pull requests that track the continued development of Django versions, and generally do not accept new features or code formatting changes.

[tomchristie]

With that in mind, I'm -1 for this change, unless we find a way to rephrase the note from our contributing page, which currently reads

🫡

[tomchristie]

Seems reasonable to me, @browniebroke.

Less noise less churn please.