Dockerfile fixes #35
Dockerfile fixes #35
Conversation
Otherwise there's no /usr/bin/php7 and nothing works
We should leverage docker caching so builds take less time.
Dockerfile
Outdated
| @@ -22,13 +21,18 @@ RUN apk --update add \ | |||
| rm /var/cache/apk/* && \ | |||
| ln -s /usr/bin/php7 /usr/bin/php | |||
|
|
|||
| COPY composer.json /usr/src/app/composer.json | |||
There was a problem hiding this comment.
You can use a pattern for these two files to avoid the extra layer. Also, since the WORKDIR is already set to /usr/src/app above, you can use ./ for the second argument:
COPY composer.* ./There was a problem hiding this comment.
nice. I see this works, but tbh I don't totally understand it. the COPY directive knows to copy files relative to the Dockerfile into the workdir? cp composer.* ./ wouldn't do anything, but I shouldn't think of COPY and cp as conceptually the same thing, huh?
There was a problem hiding this comment.
Right. COPY in a Dockerfile does not have the same interface or behavior as cp.
Here's a snippet from the docs:
COPY <src>... <dest>Multiple resources may be specified but they must be relative to the source directory that is being built (the context of the build).
Each may contain wildcards and matching will be done using Go’s filepath.Match rules.
The is an absolute path, or a path relative to WORKDIR, into which the source will be copied inside the destination container.
https://docs.docker.com/engine/reference/builder/#copy
Dockerfile
Outdated
| RUN apk --update add curl && \ | ||
| curl -sS https://getcomposer.org/installer | php && \ | ||
| ./composer.phar install && \ | ||
| apk del curl && \ | ||
| rm /usr/src/app/composer.phar \ | ||
| /var/cache/apk/* | ||
|
|
||
| COPY bin/build-content /usr/src/app/bin/build-content |
There was a problem hiding this comment.
What do you think of adding the bin/ directory to the COPY directive above to avoid this extra layer? It's rare that these bin files change so I think we can take the cache miss when they do.
There was a problem hiding this comment.
Hm I like that idea, but how do you write that? Trying
COPY composer.*|bin ./
But that ... does not seem to work 😅
There was a problem hiding this comment.
I would try:
COPY composer.* bin/ ./There was a problem hiding this comment.
Hm. it seems to copy the contents of bin, into /, not bin itself. From reading the docs, I'm not sure if there's a way to get around that
There was a problem hiding this comment.
Hmmm, could you try without the trailing slash? I think there's a difference in behavior there:
COPY composer.* bin ./There was a problem hiding this comment.
I think that behavior difference only applies to the <dest> parameter. I'm getting the same result both ways
There was a problem hiding this comment.
The behavior is a little confusing. Looks like when the <dest> has a trailing slash, the contents of the <src>s are copied in. If you want to copy an entire directory, you need to specify a specific destination: COPY bin ./bin
Unfortunately this means you can't mix and match so I think keeping the bin/build-content COPY line where you have it is fine 👌
There was a problem hiding this comment.
COPY bin/build-content /usr/src/app/bin/build-contentYou can use a relative destination though:
COPY bin/build-content ./bin/build-content
Dockerfile
Outdated
| @@ -37,6 +41,8 @@ RUN apk --update add build-base ca-certificates ruby ruby-dev && \ | |||
| apk del build-base ca-certificates ruby ruby-dev && \ | |||
| rm /var/cache/apk/* | |||
|
|
|||
| COPY . /usr/src/app | |||
There was a problem hiding this comment.
The second argument here can also change to ./ since the WORKDIR is still /usr/src/app
feeling maximally minimalist
While pursuing an unrelated bug, I noticed the engine wasn't building.