Avoid printing a php notice for each issue #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdiggs
approved these changes
Mar 21, 2017
|
Side note: Should we be tracking test coverage for this repo with our php test reporter? |
I'm 👍 on that. Increasing the coverage would help catch this kind of thing, and this codebase is small enough that it wouldn't be too hard to cover all/most of the public functions. For what it's worth, this change isn't an urgent bug fix, it's just to help remove some noise while debugging another issue. |
dblandin
approved these changes
Mar 21, 2017
af364ca to
abd1978
Compare
The interpreter wants us to do this `end` shenanigan. Getting this method under test actually _required_ us to avoid the notice, which is kind of cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter wants us to do this
endshenanigan. Getting thismethod under test actually required us to avoid the notice, which is
kind of cool.
(rebase, update target branch, and merge after #35)
Should help with #33.