You need to check for both the vowels and consonants, but do not forget to check for both the uppercase as well lowercase.
For counting vowels, check for “aeiou” characters separately i.e.
if (myStr[i] == 'a' || myStr[i] == 'e' || myStr[i] == 'i' || myStr[i] == 'o' || myStr[i] == 'u' || myStr[i] == 'A' || myStr[i] == 'E' || myStr[i] == 'I' || myStr[i] == 'O' || myStr[i] == 'U') {
vowel_count++;
}Example
The following is the code to count the number of Vowels in a string.
using System;
public class Demo {
public static void Main() {
string myStr;
int i, len, vowel_count, cons_count;
myStr = "Avengers";
vowel_count = 0;
cons_count = 0;
// find length
len = myStr.Length;
for(i=0; i<len; i++) {
if(myStr[i] =='a' || myStr[i]=='e' || myStr[i]=='i' || myStr[i]=='o' || myStr[i]=='u' || myStr[i]=='A' || myStr[i]=='E' || myStr[i]=='I' || myStr[i]=='O' || myStr[i]=='U') {
vowel_count++;
} else {
cons_count++;
}
}
Console.Write("\nVowels in the string: {0}\n", vowel_count);
}
}Output
Vowels in the string: 3