jnode-svn-commits Mailing List for JNode: new Java Operating System

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Revision: 5724
          http://jnode.svn.sourceforge.net/jnode/?rev=5724&view=rev
Author:   lsantha
Date:     2010-01-30 20:57:16 +0000 (Sat, 30 Jan 2010)

Log Message:
-----------
Findbus fixes: removed unneeded checks (condition is always false)

Modified Paths:
--------------
    trunk/core/src/core/org/jnode/vm/x86/compiler/l1a/DoubleWordItem.java
    trunk/core/src/core/org/jnode/vm/x86/compiler/l1b/DoubleWordItem.java

Modified: trunk/core/src/core/org/jnode/vm/x86/compiler/l1a/DoubleWordItem.java
===================================================================

--- trunk/core/src/core/org/jnode/vm/x86/compiler/l1a/DoubleWordItem.java	2010-01-30 20:56:41 UTC (rev 5723)
+++ trunk/core/src/core/org/jnode/vm/x86/compiler/l1a/DoubleWordItem.java	2010-01-30 20:57:16 UTC (rev 5724)
@@ -217,8 +217,8 @@
      * Gets the offset from this item to the FramePointer register. This is only
      * valid if this item has a LOCAL kind.
      *
-     * @return In 32-bit mode, use {@link #getLsbOffsetToFP()}or
-     *         {@link #getMsbOffsetToFP()}instead.
+     * @return In 32-bit mode, use {@link #getLsbOffsetToFP(EmitterContext)} or
+     * {@link #getMsbOffsetToFP(EmitterContext)} instead.
      */
     final short getOffsetToFP(EmitterContext ec) {
         if (ec.getStream().isCode32()) {
@@ -736,7 +736,7 @@
     }
 
     /**
-     * @see org.jnode.vm.x86.compiler.l1a.Item#spill(EmitterContext, Register)
+     * @see org.jnode.vm.x86.compiler.l1a.Item#spill(EmitterContext, org.jnode.assembler.x86.X86Register)
      */
     final void spill(EmitterContext ec, X86Register reg) {
         final X86Assembler os = ec.getStream();
@@ -771,7 +771,7 @@
     }
 
     /**
-     * @see org.jnode.vm.x86.compiler.l1a.Item#uses(org.jnode.assembler.x86.Register)
+     * @see org.jnode.vm.x86.compiler.l1a.Item#uses(org.jnode.assembler.x86.X86Register)
      */
     final boolean uses(X86Register reg) {
         return (isGPR() && ((this.msb == reg) || (this.lsb == reg) || (this.reg == reg)));
@@ -780,7 +780,7 @@
     /**
      * enquire whether the item uses a volatile register
      *
-     * @param reg
+     * @param pool
      * @return true, when this item uses a volatile register.
      */
     final boolean usesVolatileRegister(X86RegisterPool pool) {
@@ -810,19 +810,10 @@
                     if (msb == null) {
                         throw new IllegalStateException("msb cannot be null");
                     }
-                    if (!(lsb instanceof GPR32)) {
-                        throw new IllegalStateException("lsb must be GPR32");
-                    }
-                    if (!(msb instanceof GPR32)) {
-                        throw new IllegalStateException("msb must be GPR32");
-                    }
                 } else {
                     if (reg == null) {
                         throw new IllegalStateException("reg cannot be null");
                     }
-                    if (!(reg instanceof GPR64)) {
-                        throw new IllegalStateException("reg must be GPR64");
-                    }
                 }
                 break;
         }

Modified: trunk/core/src/core/org/jnode/vm/x86/compiler/l1b/DoubleWordItem.java
===================================================================
--- trunk/core/src/core/org/jnode/vm/x86/compiler/l1b/DoubleWordItem.java	2010-01-30 20:56:41 UTC (rev 5723)
+++ trunk/core/src/core/org/jnode/vm/x86/compiler/l1b/DoubleWordItem.java	2010-01-30 20:57:16 UTC (rev 5724)
@@ -217,8 +217,8 @@
      * Gets the offset from this item to the FramePointer register. This is only
      * valid if this item has a LOCAL kind.
      *
-     * @return In 32-bit mode, use {@link #getLsbOffsetToFP()}or
-     *         {@link #getMsbOffsetToFP()}instead.
+     * @return In 32-bit mode, use {@link #getLsbOffsetToFP(EmitterContext)} or
+     * {@link #getMsbOffsetToFP(EmitterContext)} instead.
      */
     final short getOffsetToFP(EmitterContext ec) {
         if (ec.getStream().isCode32()) {
@@ -739,7 +739,8 @@
     }
 
     /**
-     * @see org.jnode.vm.x86.compiler.l1a.Item#spill(EmitterContext, Register)
+     * @see org.jnode.vm.x86.compiler.l1a.Item#spill(org.jnode.vm.x86.compiler.l1a.EmitterContext, 
+     * org.jnode.assembler.x86.X86Register)
      */
     final void spill(EmitterContext ec, X86Register reg) {
         final X86Assembler os = ec.getStream();
@@ -774,7 +775,7 @@
     }
 
     /**
-     * @see org.jnode.vm.x86.compiler.l1a.Item#uses(org.jnode.assembler.x86.Register)
+     * @see org.jnode.vm.x86.compiler.l1a.Item#uses(org.jnode.assembler.x86.X86Register)
      */
     final boolean uses(X86Register reg) {
         return (isGPR() && ((this.msb == reg) || (this.lsb == reg) || (this.reg == reg)));
@@ -783,7 +784,7 @@
     /**
      * enquire whether the item uses a volatile register
      *
-     * @param reg
+     * @param pool
      * @return true, when this item uses a volatile register.
      */
     final boolean usesVolatileRegister(X86RegisterPool pool) {
@@ -813,19 +814,10 @@
                     if (msb == null) {
                         throw new IllegalStateException("msb cannot be null");
                     }
-                    if (!(lsb instanceof GPR32)) {
-                        throw new IllegalStateException("lsb must be GPR32");
-                    }
-                    if (!(msb instanceof GPR32)) {
-                        throw new IllegalStateException("msb must be GPR32");
-                    }
                 } else {
                     if (reg == null) {
                         throw new IllegalStateException("reg cannot be null");
                     }
-                    if (!(reg instanceof GPR64)) {
-                        throw new IllegalStateException("reg must be GPR64");
-                    }
                 }
                 break;
         }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




2006	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec (97)
2007	Jan (127)	Feb (34)	Mar (16)	Apr (26)	May (55)	Jun (107)	Jul (36)	Aug (72)	Sep (90)	Oct (41)	Nov (27)	Dec (13)
2008	Jan (37)	Feb (39)	Mar (98)	Apr (115)	May (134)	Jun (120)	Jul (86)	Aug (149)	Sep (68)	Oct (66)	Nov (104)	Dec (49)
2009	Jan (131)	Feb (132)	Mar (125)	Apr (172)	May (161)	Jun (43)	Jul (47)	Aug (38)	Sep (18)	Oct (6)	Nov (1)	Dec (15)
2010	Jan (21)	Feb (8)	Mar (10)	Apr (4)	May (9)	Jun	Jul (1)	Aug	Sep	Oct (2)	Nov	Dec (4)
2011	Jan (23)	Feb (10)	Mar (13)	Apr (3)	May	Jun (19)	Jul (11)	Aug (22)	Sep	Oct (4)	Nov (2)	Dec (12)
2012	Jan (3)	Feb (4)	Mar (7)	Apr (3)	May	Jun (1)	Jul (1)	Aug (30)	Sep (3)	Oct (2)	Nov	Dec (8)
2013	Jan (3)	Feb (40)	Mar	Apr	May	Jun (1)	Jul	Aug	Sep	Oct	Nov (12)	Dec
2021	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (2)	Oct	Nov	Dec

S	M	T	W	T	F	S
					1	2 (1)
3 (11)	4	5	6	7	8	9
10 (3)	11	12	13	14	15	16
17	18	19	20	21	22	23
24	25	26	27	28	29	30 (6)
31

jnode-svn-commits Mailing List for JNode: new Java Operating System

jnode-svn-commits — Subversion commit notifications