Translator for CONTENTdm archive and library database software #968
Conversation
| "target": "/cdm/|/cdm4/", | ||
| "minVersion": "3.0.9", | ||
| "maxVersion": "", | ||
| "priority": 100, |
There was a problem hiding this comment.
This should be 270 as per #765
| header = headers[ j ].textContent; | ||
| header = camelize( header ); | ||
| } | ||
| if ( contents[ i ].textContent ) content = contents[ i ].textContent; |
There was a problem hiding this comment.
what if it's not? (content keeps the value it had in previous loop)
(as does header, above)
|
Please address the comments above to start and run the code through http://jsbeautifier.org/ using tabs for indenting. Looks like there will be further comments after that. |
| "items": [ | ||
| { | ||
| "itemType": "manuscript", | ||
| "title": "MS.15.1.2.000. Sir Robert Hart Diary: Volume 02: February 1855-July 1855", |
There was a problem hiding this comment.
this looks like the archive location is prepended to the title. Could we clean that up better?
There was a problem hiding this comment.
There are two points here. 1) In this particular catalogue record, 'MS.15.1.2.000' is given as the item title, hence it is scraped by the translator. On this occasion, the item title is redundant, but in many cases it isn't.
- The slightly awkward format is because CDM 6 has both object-level data and item-level data. These are implemented inconsistently by libraries, and it is not possible to say that either can be safely omitted. Because of the way CDM displays, libraries often choose to put essential information at the Object level, and (as in this example) simply dropping the object-level data if the item data is present would lead to some uninformative scrapes. Hence the translator combines the item information and the object level data.
There was a problem hiding this comment.
It looks for me that MS.15.1.2.000 is just a single page and the diary contains several pages, e.g. MS.15.1.2.005 stands for page number 5.
There was a problem hiding this comment.
Exactly.
On 3 Nov 2015, at 12:05, Philipp Zumstein [email protected] wrote:
In CONTENTdm.js:
- } else {
- scrape( doc, url );
- }
+}
+/** BEGIN TEST CASES **/
+var testCases = [
- {
"type": "web","url": "http://cdm15979.contentdm.oclc.org/cdm/compoundobject/collection/p15979coll3/id/2419","items": [{"itemType": "manuscript","title": "MS.15.1.2.000. Sir Robert Hart Diary: Volume 02: February 1855-July 1855",—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
OK, great. Leave as is, then; one less thing to fix.
|
@emmareisz I think the needed changes are fairly small -- are you interested in finishing this translator up still? |
|
Hi @adam3smith - yes, I've been using the CONTENTdm translator and sharing it with colleagues, so I'd like to get it incorporated into Zotero. CONTENTdm's also had an update in the meantime. I should have some time over Christmas to finish it. I'd like to get the BNA translator finished first, though, if that's ok - could you take a quick look at it and then I'll do a PR? |
|
Yes of course -- I left a comment there. |
|
@emmareisz, any progress on this or the BNA translator? I would love to get all this merged! |
|
Just pottering along using them privately! I'll email you @AbeJellinek |
Translator for CONTENTdm archive and library database software, v6 with limited support for v4 and v5.