-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
National Post -> Postmedia #3282
base: master
Are you sure you want to change the base?
Conversation
Thanks! Nice regex :) Tests and lint should work if you rebase on I'm hesitant to merge translators that are basically just JSON-LD parsers, because I really would like to make them unnecessary by finishing up #1897 soon. But this adds support for so many sites at once that I do think it makes sense to merge now. |
5590157
to
38815af
Compare
…use the same format From list at https://www.postmedia.com/brands/
I probably put a bit too much time into writing that :p
Rebased on
I wondered if there was a universal JSON-LD translator while working on this as well, glad to hear one is being worked on! |
First fixed the NP translator, so the tests pass again.
Since all newspaper sites owned by Postmedia (parent of National Post) use the exact same layout, I've expanded the translator to include the 103 other newspapers and websites that Postmedia owns based on the list at https://www.postmedia.com/brands/. I've included some tests to confirm it works on these other websites.