Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

National Post -> Postmedia #3282

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

National Post -> Postmedia #3282

wants to merge 7 commits into from

Conversation

geofferb
Copy link
Contributor

First fixed the NP translator, so the tests pass again.

Since all newspaper sites owned by Postmedia (parent of National Post) use the exact same layout, I've expanded the translator to include the 103 other newspapers and websites that Postmedia owns based on the list at https://www.postmedia.com/brands/. I've included some tests to confirm it works on these other websites.

@geofferb geofferb changed the title Fix National Post translator and expand to all Postmedia sites National Post -> Postmedia Mar 25, 2024
@AbeJellinek
Copy link
Member

Thanks! Nice regex :)

Tests and lint should work if you rebase on master.

I'm hesitant to merge translators that are basically just JSON-LD parsers, because I really would like to make them unnecessary by finishing up #1897 soon. But this adds support for so many sites at once that I do think it makes sense to merge now.

@geofferb
Copy link
Contributor Author

geofferb commented Apr 5, 2024

@AbeJellinek

Thanks! Nice regex :)

I probably put a bit too much time into writing that :p

Tests and lint should work if you rebase on master.

Rebased on master and did a force push, and it's still failing; am I missing something?

I'm hesitant to merge translators that are basically just JSON-LD parsers, because I really would like to make them unnecessary by finishing up #1897 soon. But this adds support for so many sites at once that I do think it makes sense to merge now.

I wondered if there was a universal JSON-LD translator while working on this as well, glad to hear one is being worked on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants