Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a translator for khan.co.kr #3207

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

saschanaz
Copy link
Contributor

No description provided.

@saschanaz
Copy link
Contributor Author

Hmm, the last test failure doesn't seem to be my fault...

Done. ChromeDriver binary available at /home/runner/work/translators/translators/node_modules/chromedriver/lib/chromedriver/chromedriver
Translator server is running on http://localhost:8085
TimeoutError: Waiting for element to be located By(css selector, *[id="btn-extensions-value"])
Wait timed out after 60142ms
    at /home/runner/work/translators/translators/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  remoteStacktrace: ''
}
Some translator tests failed
Error: Process completed with exit code 1.

"translatorID": "febee9a3-4a86-42ef-87bb-31998806363b",
"label": "Kyunghyang",
"creator": "Kagami Sascha Rosylight",
"target": "^https://\\w+\\.khan\\.co\\.kr/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we just trying to match www and search with the \w+?

"type": "web",
"url": "https://search.khan.co.kr/search.html?sect=1&path=1&q=+%EB%84%A5%EC%8A%A8",
"detectedItemType": "multiple",
"items": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't seem right - it detected a multiple and then saved the search page as an article?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants