Skip to content

Commit

Permalink
Merge branch '3.7-dev'
Browse files Browse the repository at this point in the history
  • Loading branch information
xiazcy committed Jul 17, 2024
2 parents 2bfd44b + ef466de commit 5697d07
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ This release also includes changes from <<release-3-6-8, 3.6.8>>.
* Fixed so that `TrimGlobalStep` and `TrimLocalStep` have the same character control handling as `Ltrim` and `Rtrim`
* Fix a bug in `MaxLocalStep`, `MinLocalStep`, `MeanLocalStep` and `SumLocalStep` that it throws `NoSuchElementException` when encounters an empty iterator as input.
* Fix cases where Map keys of incomparable types could panic in `gremlin-go`.
* Fixed an issue where missing necessary parameters for logging, resulting in '%!x(MISSING)' output in `gremlin-go`.
* Added getter method to `ConcatStep`, `ConjoinStep`, `SplitGlobalStep` and `SplitLocalStep` for their private fields.
[[release-3-7-2]]
Expand Down
2 changes: 1 addition & 1 deletion gremlin-go/driver/graphBinary.go
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ func readMapUnqualified(data *[]byte, i *int) (interface{}, error) {
for j := uint32(0); j < sz; j++ {
keyDataType := readDataType(data, i)
if keyDataType != stringType {
return nil, newError(err0703ReadMapNonStringKeyError)
return nil, newError(err0703ReadMapNonStringKeyError, keyDataType)
}

// Skip nullable, key must be present
Expand Down
2 changes: 1 addition & 1 deletion gremlin-go/driver/graphBinary_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func TestGraphBinaryV1(t *testing.T) {
buff := []byte{0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00, 0x00, 0x01}
m, err := readMapUnqualified(&buff, &i)
assert.Nil(t, m)
assert.Equal(t, newError(err0703ReadMapNonStringKeyError), err)
assert.Equal(t, newError(err0703ReadMapNonStringKeyError, intType), err)
})
})
}

0 comments on commit 5697d07

Please sign in to comment.