Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort stream on exit #17

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Abort stream on exit #17

merged 1 commit into from
Jun 7, 2022

Conversation

refarer
Copy link
Collaborator

@refarer refarer commented Jun 2, 2022

Problem

Stream hang on break #16

Solution

Added AbortController to abort after exit

@refarer refarer linked an issue Jun 2, 2022 that may be closed by this pull request
Hang when breaking out of stream #16
Closed
@refarer refarer requested a review from lagache June 6, 2022 21:35
@lagache
Copy link
Contributor

lagache commented Jun 7, 2022

LGTM
Though an example would be great

@refarer refarer merged commit f02dd3c into main Jun 7, 2022
@refarer refarer deleted the 16-hang-when-breaking-out-of-stream branch June 7, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagache lagache lagache approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang when breaking out of stream
2 participants
@refarer @lagache