Skip to content

remove dry_run from filtered stream example #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

remove dry_run from filtered stream example #10

merged 1 commit into from
May 2, 2022
+0 −3

Conversation

refarer
Copy link
Collaborator

@refarer refarer commented May 2, 2022

Problem

It is confusing having dry_run: true in the example code, because the stream doesn't work without rules

Solution

Remove dry_run: true

@refarer refarer linked an issue May 2, 2022 that may be closed by this pull request
Filtered-stream example not working OOB #9
Closed
@refarer refarer requested a review from lagache May 2, 2022 23:28
@refarer refarer merged commit 797123a into main May 2, 2022
@refarer refarer deleted the 9-filtered-stream-example-not-working-oob branch May 2, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagache lagache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtered-stream example not working OOB
2 participants
@refarer @lagache