java.nio.file.Path converter #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm unclear on the Travis CI requirements because, for example, com.thoughtworks.acceptance.LambdaTest clearly requires Java 8. thanks |
Member
|
Hi Aaron, thanks for the contribution. You may rewrite the PathConverter using no reflection, it is fine for me, if Travis passes JDK 8+7 builds. I will tweak the Maven build to support the older JDKs (the converter will actually be excluded). |
remove some reflection. make the jdk 1.6 build work.
Contributor
Author
|
Great! I've removed the reflection from the converter. I left it for the call to xstream.alias() though because it creates an alias based on the concrete implementation of java.nio.file.Path (e.g. sun.nio.fs.UnixPath, sun.nio.fs.WindowsFileSystem). I couldn't find a precedent for this in the code. I couldn't find a way to re-launch the Travis CI builds. |
joehni
pushed a commit
that referenced
this pull request
Feb 13, 2016
joehni
pushed a commit
that referenced
this pull request
Feb 13, 2016
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a java.nio.file.Path converter for enhancement request #33